Skip to content

chore: remove warnings for assertNotRegexpMatches method#32753

Merged
UsamaSadiq merged 1 commit intoopenedx:masterfrom
bitmakerla:diegovr/rm-deprecated-warning
Jul 27, 2023
Merged

chore: remove warnings for assertNotRegexpMatches method#32753
UsamaSadiq merged 1 commit intoopenedx:masterfrom
bitmakerla:diegovr/rm-deprecated-warning

Conversation

@diegovr
Copy link
Contributor

@diegovr diegovr commented Jul 14, 2023

Description

Issue: openedx/public-engineering#157

  • Replace the assertNotRegexpMatches with assertNotRegex method. This will remove the DeprecationWarning logs.

Supporting information

Python 3 renamed assertRegexpMatches to assertRegex, and assertNotRegexpMatches to assertNotRegex.

However, they did not add an alias for assertNotRegexpMatches until Python 3.5 (see https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertNotRegex)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 14, 2023 •
edited
Loading

Thanks for the pull request, @diegovr! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@diegovr diegovr changed the title [WIP] chore: remove warnings for assertNotRegexpMatches method chore: remove warnings for assertNotRegexpMatches method Jul 14, 2023
@diegovr diegovr marked this pull request as ready for review July 14, 2023 22:45
@diegovr
Copy link
Contributor Author

diegovr commented Jul 14, 2023

@e0d could you please enable the tests to run

@diegovr
Copy link
Contributor Author

diegovr commented Jul 17, 2023

Hi @e0d - The pipeline is 🟢.

@e0d e0d requested a review from UsamaSadiq July 17, 2023 15:41
@e0d
Copy link
Contributor

e0d commented Jul 17, 2023

@UsamaSadiq this PR was submitted based on an issue you authored. Are you the best reviewer?

@eLRuLL
Copy link
Contributor

eLRuLL commented Jul 26, 2023

@UsamaSadiq could you please review this PR?

@UsamaSadiq UsamaSadiq merged commit e92e0e2 into openedx:master Jul 27, 2023
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Jul 27, 2023

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Jul 27, 2023

2U Release Notice: This PR has been deployed to the edX production environment.

@diegovr diegovr deleted the diegovr/rm-deprecated-warning branch July 27, 2023 15:14
@kenclary kenclary mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@diegovr @openedx-webhooks @e0d @eLRuLL @edx-pipeline-bot @UsamaSadiq